Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert permission refactoring PR #21313

Merged

Conversation

zephyring
Copy link

@zephyring zephyring commented Sep 2, 2022

SUMMARY

  1. This PR reverts https://github.com/apache/superset/pull/21156/files and https://github.com/apache/superset/pull/21208/files
  2. The first PR skips using security_manager.get_role_permissions method here, which breaks FAB builtin roles.
  3. The second PR is built on first PR.
  4. We should probably do the performance refactoring inside FAB.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zephyring zephyring closed this Sep 2, 2022
@zephyring zephyring force-pushed the zef/ch56792/revert-permission-refactor branch from 1a3d5f8 to 34a79ad Compare September 2, 2022 19:09
@zephyring zephyring reopened this Sep 2, 2022
@pull-request-size pull-request-size bot added size/L and removed size/XS labels Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #21313 (787cc1a) into master (34a79ad) will increase coverage by 0.00%.
The diff coverage is 16.66%.

❗ Current head 787cc1a differs from pull request most recent head 5b19664. Consider uploading reports for the commit 5b19664 to get more accurate results

@@           Coverage Diff           @@
##           master   #21313   +/-   ##
=======================================
  Coverage   55.07%   55.08%           
=======================================
  Files        1789     1789           
  Lines       68376    68370    -6     
  Branches     7275     7275           
=======================================
+ Hits        37658    37659    +1     
+ Misses      28843    28836    -7     
  Partials     1875     1875           
Flag Coverage Δ
hive 52.96% <16.66%> (+0.01%) ⬆️
presto 52.86% <16.66%> (+0.01%) ⬆️
python 57.83% <16.66%> (+0.01%) ⬆️
unit 50.88% <16.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 63.30% <ø> (+1.91%) ⬆️
superset/views/utils.py 38.69% <16.66%> (-1.72%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zephyring zephyring force-pushed the zef/ch56792/revert-permission-refactor branch from 5b19664 to 2803c93 Compare September 2, 2022 19:18
@zephyring zephyring changed the title Zef/ch56792/revert permission refactor fix: revert permission refactoring PR Sep 2, 2022
@dpgaspar dpgaspar merged commit 286474c into apache:master Sep 6, 2022
@dpgaspar dpgaspar deleted the zef/ch56792/revert-permission-refactor branch September 6, 2022 18:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants