chore: refactor SqlEditor to functional component

[EugeneTorap]

SUMMARY

Converted SqlEditor class component into functional component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21320 (5bf09a3) into master (8c16806) will increase coverage by 0.00%.
The diff coverage is 53.28%.

@@           Coverage Diff           @@
##           master   #21320   +/-   ##
=======================================
  Coverage   66.66%   66.67%           
=======================================
  Files        1793     1793           
  Lines       68490    68501   +11     
  Branches     7275     7274    -1     
=======================================
+ Hits        45662    45676   +14     
+ Misses      20966    20965    -1     
+ Partials     1862     1860    -2     

Flag	Coverage Δ
javascript	52.85% <53.28%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/SqlLab/components/SqlEditor/index.jsx	52.74% <51.36%> (+1.33%)	⬆️
superset-frontend/src/SqlLab/constants.ts	100.00% <100.00%> (ø)
...et-frontend/src/components/TableSelector/index.tsx	80.00% <0.00%> (+4.00%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kgabryje]

@jinghua-qa Could you please help testing?

[kgabryje]

/testenv up

[github-actions]

@kgabryje Ephemeral environment spinning up at http://35.86.124.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[lyndsiWilliams]

I found a few things that need adjustment, as well as these items that I was unable to tag separately:

• Move the consts on these lines (85-90) to the constants file at superset-frontend/src/SqlLab/constants.ts
• Change the padding for StyledSidebar on line 134 to use gridUnits instead of 10

[kgabryje]

/testenv up

[github-actions]

@kgabryje Ephemeral environment spinning up at http://52.33.78.124:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[EugeneTorap]

@lyndsiWilliams @andrey-zayats Can you review/test it?

[andrey-zayats]

User can't update the saved query. The issue is not reproduced in the latest master

upd.mp4

[andrey-zayats]

An error message occurs when user selects a schema from "schema" dropdown. There is also no data in the table schema dropdown. I checked it locally and on eph env, reproduced on both

error.mp4

[lyndsiWilliams]

Good catch @andrey-zayats, that bug will need to be fixed before this PR can be merged.

[EugeneTorap]

@lyndsiWilliams master branch has this bug

[lyndsiWilliams]

There's a fix being worked on for this now, let's wait until that fix is in so QA can properly test this PR.

[EugeneTorap]

@lyndsiWilliams @jinghua-qa @andrey-zayats Can you review/test it?

[jinghua-qa]

/testenv up

[github-actions]

@jinghua-qa Ephemeral environment spinning up at http://35.92.222.234:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[EugeneTorap]

@jinghua-qa @andrey-zayats Can you test it?

[andrey-zayats]

@jinghua-qa @andrey-zayats Can you test it?

I'll take a look tomorrow morning

[andrey-zayats]

@EugeneTorap QA verified. LGTM

UDP:
FYI. There is an error message occurs when user saves a chart using chart power query. This issue is already in master

empty.query.mp4

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.