Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use slim image in Dockerfile #21326

Merged
merged 4 commits into from
Sep 19, 2022
Merged

chore: Use slim image in Dockerfile #21326

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3855a4
chore: Use slim image in Dockerfile and bump python to 3.9
EugeneTorap Sep 5, 2022
03a81c8
Fix bug
EugeneTorap Sep 5, 2022
21f31c7
Add wget
EugeneTorap Sep 5, 2022
53407f2
Use python 3.8
EugeneTorap Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
######################################################################
# PY stage that simply does a pip install on our requirements
######################################################################
ARG PY_VER=3.8.13
ARG PY_VER=3.8.13-slim
FROM python:${PY_VER} AS superset-py

RUN mkdir /app \
Expand All @@ -45,10 +45,7 @@ RUN cd /app \
######################################################################
# Node stage to deal with static asset construction
######################################################################
FROM node:16 AS superset-node

ARG NPM_VER=7
RUN npm install -g npm@${NPM_VER}
FROM node:16-slim AS superset-node
EugeneTorap marked this conversation as resolved.
Show resolved Hide resolved

ARG NPM_BUILD_CMD="build"
ENV BUILD_CMD=${NPM_BUILD_CMD}
Expand All @@ -71,7 +68,7 @@ RUN cd /app/superset-frontend \
######################################################################
# Final lean image...
######################################################################
ARG PY_VER=3.8.13
ARG PY_VER=3.8.13-slim
FROM python:${PY_VER} AS lean

ENV LANG=C.UTF-8 \
Expand Down Expand Up @@ -133,7 +130,7 @@ COPY ./requirements/*.txt ./docker/requirements-*.txt/ /app/requirements/
USER root

RUN apt-get update -y \
&& apt-get install -y --no-install-recommends libnss3 libdbus-glib-1-2 libgtk-3-0 libx11-xcb1
&& apt-get install -y --no-install-recommends libnss3 libdbus-glib-1-2 libgtk-3-0 libx11-xcb1 wget

# Install GeckoDriver WebDriver
RUN wget https://github.com/mozilla/geckodriver/releases/download/${GECKODRIVER_VERSION}/geckodriver-${GECKODRIVER_VERSION}-linux64.tar.gz -O /tmp/geckodriver.tar.gz && \
Expand Down