Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): menu improvements, fallback support for Drill to Detail #21351

Merged
merged 38 commits into from
Oct 19, 2022
Merged

feat(dashboard): menu improvements, fallback support for Drill to Detail #21351

merged 38 commits into from
Oct 19, 2022

Commits on Oct 19, 2022

  1. Refactor D2D menu/modal.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ddebcea View commit details
    Browse the repository at this point in the history

  2. Implement/test fallback menu.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    2899160 View commit details
    Browse the repository at this point in the history

  3. Implement/test menu for supported chart w/o filters.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    17622bb View commit details
    Browse the repository at this point in the history

  4. Stub out todo tests.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0f3d59a View commit details
    Browse the repository at this point in the history

  5. Refactor components, tests.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c1da35e View commit details
    Browse the repository at this point in the history

  6. WIP

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    4bc91eb View commit details
    Browse the repository at this point in the history

  7. WIP

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    5894d03 View commit details
    Browse the repository at this point in the history

  8. WIP

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    2f3b4f2 View commit details
    Browse the repository at this point in the history

  9. Implement/test rest of menu items.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    94e3b43 View commit details
    Browse the repository at this point in the history

  10. Fixes

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ba0eb71 View commit details
    Browse the repository at this point in the history

  11. Typing, other cleanup.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    143a273 View commit details
    Browse the repository at this point in the history

  12. Disable D2D menu if user doesn't have explore permissions.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    f0aaa8b View commit details
    Browse the repository at this point in the history

  13. Update menu placement.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ac720d1 View commit details
    Browse the repository at this point in the history

  14. Typing, param cleanup.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    019a046 View commit details
    Browse the repository at this point in the history

  15. Cleanup

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0479c23 View commit details
    Browse the repository at this point in the history

  16. Update behavior name.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    5d2a86c View commit details
    Browse the repository at this point in the history

  17. Fix failing test.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    cc49b90 View commit details
    Browse the repository at this point in the history

  18. Fix Cypress tests.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    995fcb8 View commit details
    Browse the repository at this point in the history

  19. Cleanup.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c1a8321 View commit details
    Browse the repository at this point in the history

  20. Fix broken Table and Pivot Table charts.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d915f5f View commit details
    Browse the repository at this point in the history

  21. Use QueryMode enum.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    9c619e7 View commit details
    Browse the repository at this point in the history

  22. Move submenu messages to tooltips, retrigger CI, retrigger CI.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    cce3d03 View commit details
    Browse the repository at this point in the history

  23. Make modal mask block contextmenu events.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0f0c0b0 View commit details
    Browse the repository at this point in the history

  24. Add missing D2D behavior.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d8e3bb1 View commit details
    Browse the repository at this point in the history

  25. Clean up import.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c85eb38 View commit details
    Browse the repository at this point in the history

  26. Use enum for chart source.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    422cfa1 View commit details
    Browse the repository at this point in the history

  27. Update Cypress tests.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    adf3e2f View commit details
    Browse the repository at this point in the history

  28. Better fix for disabling right-click with modal open.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    64aa996 View commit details
    Browse the repository at this point in the history

  29. Remove accidental duplicate tests.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d9b4303 View commit details
    Browse the repository at this point in the history

  30. Remove extra space from comments.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    14c4496 View commit details
    Browse the repository at this point in the history

  31. Change onContextMenu function signature.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    7851d68 View commit details
    Browse the repository at this point in the history

  32. Make menu max width not dependent on grid unit.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0437083 View commit details
    Browse the repository at this point in the history

  33. Replace noAggregations metadata function with metric check.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    4b97388 View commit details
    Browse the repository at this point in the history

  34. Use BinaryQueryObjectFilterClause consistently.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    9cfcc39 View commit details
    Browse the repository at this point in the history

  35. Rename variables.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    4c57264 View commit details
    Browse the repository at this point in the history

  36. Restructure if/else blocks for readability.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    8bc9476 View commit details
    Browse the repository at this point in the history

  37. Make enum PascalCase.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    bb43302 View commit details
    Browse the repository at this point in the history

  38. Fix no aggregations message appearing on unsupported charts.

    @codyml
    codyml committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    85d080f View commit details
    Browse the repository at this point in the history