-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-chart-echarts): able to sort bar on the bar chart V2 #21356
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21356 +/- ##
==========================================
+ Coverage 66.47% 66.57% +0.10%
==========================================
Files 1789 1791 +2
Lines 68381 68444 +63
Branches 7276 7297 +21
==========================================
+ Hits 45455 45568 +113
+ Misses 21051 20996 -55
- Partials 1875 1880 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@rusackas Ephemeral environment spinning up at http://52.25.229.84:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR supports sorting bar on the bar chart V2. The key point is using the label in metrcs or columns to sort. If orderBy can't find these lists, just don't use the sort operator, it's a limitation.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
2022-09-07.8.46.59.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION