Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(database): raised version of sqlalchemy-kusto #21370

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

xneg
Copy link
Contributor

@xneg xneg commented Sep 8, 2022

  • Raised version of sqlalchemy-kusto to 2.0.0.
  • Added information about kusto connection in docs/databases.

SUMMARY

Since sqlalchemy version was raised to >=1.4 we need to use sqlalchemy-kusto>=2.0.0 which is compatible with sqlalchemy>=1.4.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #21370 (ba423b0) into master (b302818) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head ba423b0 differs from pull request most recent head 1e15a12. Consider uploading reports for the commit 1e15a12 to get more accurate results

@@            Coverage Diff             @@
##           master   #21370      +/-   ##
==========================================
- Coverage   66.61%   66.43%   -0.18%     
==========================================
  Files        1791     1791              
  Lines       68538    68538              
  Branches     7310     7310              
==========================================
- Hits        45655    45536     -119     
- Misses      21002    21121     +119     
  Partials     1881     1881              
Flag Coverage Δ
hive ?
mysql 80.83% <ø> (ø)
postgres 80.88% <ø> (ø)
presto ?
python 81.00% <ø> (-0.36%) ⬇️
sqlite 79.43% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 71.09% <0.00%> (-16.02%) ⬇️
superset/db_engine_specs/presto.py 81.32% <0.00%> (-6.63%) ⬇️
superset/models/sql_lab.py 74.90% <0.00%> (-2.00%) ⬇️
superset/initialization/__init__.py 90.00% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 89.90% <0.00%> (-0.70%) ⬇️
superset/db_engine_specs/base.py 88.01% <0.00%> (-0.32%) ⬇️
superset/models/core.py 88.81% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.88% <0.00%> (-0.12%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks especially for the added docs!

@villebro villebro merged commit ac7dcc3 into apache:master Sep 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants