Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix act errors in AddDataset test #21381

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This PR fixes 3 act errors in superset-frontend/src/views/CRUD/data/dataset/AddDataset/AddDataset.test.tsx

TESTING INSTRUCTIONS

  • cd into superset-frontend/src/views/CRUD/data/dataset/AddDataset
  • run npm run test superset-frontend/src/views/CRUD/data/dataset/AddDataset/AddDataset.test.tsx
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #21381 (4fd341d) into master (834ec7e) will increase coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 4fd341d differs from pull request most recent head 276c42c. Consider uploading reports for the commit 276c42c to get more accurate results

@@            Coverage Diff             @@
##           master   #21381      +/-   ##
==========================================
+ Coverage   66.44%   66.61%   +0.16%     
==========================================
  Files        1791     1791              
  Lines       68559    68559              
  Branches     7319     7319              
==========================================
+ Hits        45557    45671     +114     
+ Misses      21116    21002     -114     
  Partials     1886     1886              
Flag Coverage Δ
javascript 52.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/core.py 90.00% <0.00%> (+0.11%) ⬆️
superset/models/core.py 89.04% <0.00%> (+0.23%) ⬆️
superset/db_engine_specs/base.py 88.32% <0.00%> (+0.31%) ⬆️
superset/connectors/sqla/models.py 90.60% <0.00%> (+0.69%) ⬆️
superset/models/sql_lab.py 76.89% <0.00%> (+1.99%) ⬆️
superset/db_engine_specs/presto.py 87.95% <0.00%> (+6.62%) ⬆️
superset/db_engine_specs/hive.py 87.10% <0.00%> (+16.01%) ⬆️
superset/db_engines/hive.py 85.18% <0.00%> (+85.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lyndsiWilliams lyndsiWilliams merged commit 5f9f657 into master Sep 8, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/adddataset-act-cleanup branch September 8, 2022 18:31
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants