Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump bigquery libs #21466

Merged
merged 5 commits into from
Dec 2, 2022
Merged

chore: Bump bigquery libs #21466

merged 5 commits into from
Dec 2, 2022

Conversation

EugeneTorap
Copy link
Contributor

SUMMARY

Support Python 3.10 for bigquery libs. Replacing pybigquery with sqlalchemy-bigquery

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #21466 (efb2e27) into master (2bdf22b) will increase coverage by 9.70%.
The diff coverage is 60.00%.

❗ Current head efb2e27 differs from pull request most recent head fe6dbb9. Consider uploading reports for the commit fe6dbb9 to get more accurate results

@@            Coverage Diff             @@
##           master   #21466      +/-   ##
==========================================
+ Coverage   55.69%   65.40%   +9.70%     
==========================================
  Files        1846     1847       +1     
  Lines       70302    70333      +31     
  Branches     7689     7702      +13     
==========================================
+ Hits        39157    46001    +6844     
+ Misses      29151    22334    -6817     
- Partials     1994     1998       +4     
Flag Coverage Δ
hive ?
postgres 78.11% <ø> (?)
presto ?
python 78.18% <ø> (+20.39%) ⬆️
sqlite 76.57% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx 29.03% <0.00%> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx 6.31% <0.00%> (ø)
...end/src/filters/components/Range/transformProps.ts 100.00% <ø> (ø)
...nd/src/filters/components/Select/transformProps.ts 91.66% <ø> (ø)
...et-frontend/src/filters/components/Select/types.ts 100.00% <ø> (ø)
...d/src/filters/components/Time/TimeFilterPlugin.tsx 0.00% <ø> (ø)
...tend/src/filters/components/Time/transformProps.ts 0.00% <ø> (ø)
...perset-frontend/src/views/RootContextProviders.tsx 0.00% <0.00%> (ø)
superset/db_engine_specs/bigquery.py 70.79% <ø> (+15.34%) ⬆️
... and 334 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for breathing life into this stale dep! 🚀

@villebro villebro merged commit 7bc5f04 into apache:master Dec 2, 2022
@EugeneTorap EugeneTorap deleted the chore/bump-bigquery-libs branch December 2, 2022 10:50
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants