Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adding/categorizing missing flags in FEATURE_FLAGS.md #21474

Merged
merged 12 commits into from
Oct 4, 2022
Merged

chore: Adding/categorizing missing flags in FEATURE_FLAGS.md #21474

Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cd96ea3
Adding missing flags, and a TODO category
rusackas Sep 15, 2022
607e5ed
removing handles from the markdown since they're on the PR now.
rusackas Sep 15, 2022
44dbeaf
this comment was no longer necessary
rusackas Sep 15, 2022
715c205
linting!
rusackas Sep 15, 2022
ae61ad0
`EMBEDDABLE_CHARTS` -> Stable
rusackas Sep 16, 2022
e2cbd8f
adding a missing dash
rusackas Sep 18, 2022
51f8a28
Accepting dev feedback on categorization
rusackas Sep 20, 2022
acff33c
Apply suggestions from code review
rusackas Sep 28, 2022
cd052dc
Categorizing 3 more flags (thanks Lily!)
rusackas Sep 28, 2022
18f6794
Two more updates thanks to Arash!
rusackas Sep 28, 2022
9ebe546
Another one resolved thanks to Ryan!
rusackas Sep 28, 2022
8037e69
ALLOW_FULL_CSV_EXPORT moved to testing due to apparent risks
rusackas Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions RESOURCES/FEATURE_FLAGS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ These features are considered **unfinished** and should only be used on developm
- SHARE_QUERIES_VIA_KV_STORE
- TAGGING_SYSTEM
- ENABLE_TEMPLATE_REMOVE_FILTERS
- DRILL_TO_DETAIL
rusackas marked this conversation as resolved.
Show resolved Hide resolved

## In Testing
These features are **finished** but currently being tested. They are usable, but may still contain some bugs.
Expand All @@ -44,6 +45,14 @@ These features are **finished** but currently being tested. They are usable, but
- VERSIONED_EXPORT
- ENABLE_JAVASCRIPT_CONTROLS
- GENERIC_CHART_AXES
- ENABLE_FILTER_BOX_MIGRATION
- UX_BETA
- USE_ANALAGOUS_COLORS
- DASHBOARD_EDIT_CHART_IN_NEW_TAB
rusackas marked this conversation as resolved.
Show resolved Hide resolved
- CACHE_IMPERSONATION
- RLS_IN_SQLLAB
rusackas marked this conversation as resolved.
Show resolved Hide resolved
- DASHBOARD_FILTERS_EXPERIMENTAL
rusackas marked this conversation as resolved.
Show resolved Hide resolved


## Stable
These features flags are **safe for production** and have been tested.
Expand All @@ -57,9 +66,23 @@ These features flags are **safe for production** and have been tested.
- SQL_VALIDATORS_BY_ENGINE [(docs)](https://superset.apache.org/docs/installation/sql-templating)
- SQLLAB_BACKEND_PERSISTENCE
- THUMBNAILS [(docs)](https://superset.apache.org/docs/installation/cache)
- ENABLE_EXPLORE_DRAG_AND_DROP
- ENABLE_DND_WITH_CLICK_UX
- EMBEDDABLE_CHARTS
rusackas marked this conversation as resolved.
Show resolved Hide resolved
rusackas marked this conversation as resolved.
Show resolved Hide resolved
- DRUID_JOINS
rusackas marked this conversation as resolved.
Show resolved Hide resolved

rusackas marked this conversation as resolved.
Show resolved Hide resolved
## Deprecated Flags
These features flags currently default to True and **will be removed in a future major release**. For this current release you can turn them off by setting your config to False, but it is advised to remove or set these flags in your local configuration to **True** so that you do not experience any unexpected changes in a future release.

- ALLOW_DASHBOARD_DOMAIN_SHARDING
- DISPLAY_MARKDOWN_HTML
- FORCE_DATABASE_CONNECTIONS_SSL

## In need of categorization
- DISABLE_LEGACY_DATASOURCE_EDITOR
- EMBEDDED_SUPERSET
- ENABLE_ADVANCED_DATA_TYPES
rusackas marked this conversation as resolved.
Show resolved Hide resolved
rusackas marked this conversation as resolved.
Show resolved Hide resolved
- ALERTS_ATTACH_REPORTS
- ENFORCE_DB_ENCRYPTION_UI
- ALLOW_FULL_CSV_EXPORT
- ALLOW_ADHOC_SUBQUERY
rusackas marked this conversation as resolved.
Show resolved Hide resolved