Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct favicon from config for login and FAB list views #21498

Merged
merged 2 commits into from
Sep 19, 2022
Merged

fix: set correct favicon from config for login and FAB list views #21498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0218d44
use favicon from config file in base.html
mayurnewase Sep 17, 2022
5c348e6
use favicon from config file in base.html
mayurnewase Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion superset/templates/superset/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,15 @@

{% block head_css %}
{{ super() }}
<link rel="icon" type="image/png" href="{{ assets_prefix }}/static/assets/images/favicon.png">
{% set favicons = appbuilder.app.config['FAVICONS'] %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from https://github.com/apache/superset/blob/master/superset/templates/superset/basic.html#L38

{% for favicon in favicons %}
<link
rel="{{favicon.rel if favicon.rel else "icon"}}"
type="{{favicon.type if favicon.type else "image/png"}}"
{% if favicon.sizes %}sizes={{favicon.sizes}}{% endif %}
href="{{ "" if favicon.href.startswith("http") else assets_prefix }}{{favicon.href}}"
>
{% endfor %}
{{ css_bundle("theme") }}
{% endblock %}

Expand Down