Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(word-cloud): reduce render to improve performance #21504

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Sep 17, 2022

SUMMARY

Currently, the cloud map will re-render multiple times in the dashboard. The reason is that when determining whether to update, the object is judged using the !== operator.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

image

after

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #21504 (dea85e0) into master (6e8cad3) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21504      +/-   ##
==========================================
+ Coverage   66.59%   66.64%   +0.05%     
==========================================
  Files        1791     1793       +2     
  Lines       68554    68450     -104     
  Branches     7319     7275      -44     
==========================================
- Hits        45653    45620      -33     
+ Misses      21008    20968      -40     
+ Partials     1893     1862      -31     
Flag Coverage Δ
javascript 52.83% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns/plugin-chart-word-cloud/src/chart/WordCloud.tsx 0.00% <0.00%> (ø)
.../legacy-plugin-chart-histogram/src/controlPanel.ts 40.00% <0.00%> (-10.00%) ⬇️
superset-frontend/src/hooks/apiResources/tables.ts 80.00% <0.00%> (-1.25%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 52.38% <0.00%> (-1.20%) ⬇️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 49.61% <0.00%> (ø)
.../src/dashboard/components/RefreshIntervalModal.tsx 80.00% <0.00%> (ø)
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 66.66% <0.00%> (ø)
.../superset-ui-core/src/query/normalizeTimeColumn.ts 100.00% <0.00%> (ø)
...e/components/controls/SelectAsyncControl/index.tsx 54.83% <0.00%> (ø)
...et-ui-chart-controls/src/operators/sortOperator.ts 100.00% <0.00%> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenLYZ stephenLYZ merged commit 94a724e into apache:master Sep 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants