-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple time columns with time grain in Pivot Table v2 #21537
feat: support multiple time columns with time grain in Pivot Table v2 #21537
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21537 +/- ##
=======================================
Coverage 66.68% 66.68%
=======================================
Files 1793 1793
Lines 68538 68557 +19
Branches 7282 7289 +7
=======================================
+ Hits 45702 45718 +16
+ Misses 20974 20966 -8
- Partials 1862 1873 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/plugins/plugin-chart-pivot-table/package.json
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/buildQuery.ts
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/buildQuery.ts
Outdated
Show resolved
Hide resolved
/testenv up FEATURE_GENERIC_CHART_AXES=true |
@zhaoyongjie Ephemeral environment spinning up at http://52.34.7.237:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
If the FF Generic Axis is enabled, the Pivot Table v2 will support multiple time columns with time grain. The
TIME GRAIN
control also moves out from the time section.There is a limitation in the current design that the Adhoc Column wasn't able to apply the Time Grain, I will open separated PR to support the dynamic detector for the column type.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
The time grain is applied on
Order Date
andShip Date
The time grain is applied on
Order Date
andShip Date
exceptCategory
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION