Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): fix Pivot Table V2 dragPreview in the dashboard #21539

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-09-21.9.40.41.mov

after

2022-09-21.9.38.12.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #21539 (affc7d8) into master (7e2e8b8) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #21539   +/-   ##
=======================================
  Coverage   66.57%   66.57%           
=======================================
  Files        1793     1793           
  Lines       68493    68537   +44     
  Branches     7275     7282    +7     
=======================================
+ Hits        45596    45631   +35     
- Misses      21035    21044    +9     
  Partials     1862     1862           
Flag Coverage Δ
javascript 52.86% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n-chart-pivot-table/src/react-pivottable/Styles.js 0.00% <0.00%> (ø)
...ivot-table/src/react-pivottable/TableRenderers.jsx 0.00% <0.00%> (ø)
...frontend/src/components/ListView/Filters/index.tsx 52.17% <0.00%> (-14.50%) ⬇️
...src/dashboard/components/PropertiesModal/index.tsx 61.07% <0.00%> (-0.75%) ⬇️
...rset-frontend/src/explore/components/SaveModal.tsx 38.53% <0.00%> (-0.52%) ⬇️
superset-frontend/src/SqlLab/constants.ts 100.00% <0.00%> (ø)
...set-frontend/src/explore/actions/hydrateExplore.ts 42.10% <0.00%> (ø)
...ns/plugin-chart-word-cloud/src/chart/WordCloud.tsx 0.00% <0.00%> (ø)
...in-chart-echarts/src/MixedTimeseries/buildQuery.ts 100.00% <0.00%> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for the fix!

@rusackas
Copy link
Member

/testenv up

@stephenLYZ stephenLYZ merged commit ab53d77 into apache:master Sep 28, 2022
@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.214.216.108:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants