-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dashboard): Add filter_scopes warning message for json metadata editor #21543
chore(dashboard): Add filter_scopes warning message for json metadata editor #21543
Conversation
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx
Outdated
Show resolved
Hide resolved
9d9c011
to
49d4b77
Compare
Codecov Report
@@ Coverage Diff @@
## master #21543 +/- ##
==========================================
- Coverage 66.66% 66.65% -0.01%
==========================================
Files 1794 1794
Lines 68639 68640 +1
Branches 7300 7301 +1
==========================================
Hits 45755 45755
Misses 21014 21014
- Partials 1870 1871 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
b2ebb47
to
f525195
Compare
Can we maybe just remove those unconfigurable fields from the JSON displayed to the users---and add them back before posting to the API? I thought we had something like this for certain fields at one point, but not all and always. |
… editor (apache#21543) Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> (cherry picked from commit 2cdd88a)
… editor (apache#21543) Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> (cherry picked from commit 2cdd88a)
SUMMARY
Since the existing dashboardState overwrite the
filter_scopes
directly by the UI state from the filter mapping menu, thefilter_scopes
changes made from json metadata editor can be lost.superset/superset-frontend/src/dashboard/actions/dashboardState.js
Lines 385 to 390 in e438c96
This commit adds the warning message of
filter_scopes
changes and then links to the filter mapping menu for the alternative.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
chore--warning-filter_scopes.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION