-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds the MetadataBar to the Explore header #21560
feat: Adds the MetadataBar to the Explore header #21560
Conversation
} | ||
}) | ||
.catch(() => {}); | ||
const updateCategoricalNamespace = async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geido Can you please check if I didn't break anything here?
3815389
to
74b99e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #21560 +/- ##
==========================================
- Coverage 66.65% 65.40% -1.26%
==========================================
Files 1793 1794 +1
Lines 68559 68751 +192
Branches 7294 7325 +31
==========================================
- Hits 45701 44965 -736
- Misses 20991 21921 +930
+ Partials 1867 1865 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
Hey @michael-s-molina a few quick comments from a first look Should we add a placeholder text when there are no available owners? Spacing requires some improvement Can we make the empty space equal on both ends? |
@michael-s-molina Ephemeral environment spinning up at http://35.90.249.143:8080. Credentials are |
Added
Fixed
This is a little more complicated. Currently, we have a minimum width of |
/testenv up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. LGTM!
@geido Ephemeral environment spinning up at http://54.184.106.10:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
MetadataBar
to the Explore headerMetadataBar
resize capabilities and changes the component to work with server-side timestamps@kasiazjc I didn't add a tooltip for the number of dashboards because it requires a future PR that will increment the 3 dots menu with the list of related dashboards. This will be made in a follow-up.
@codyml @rusackas
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-09-22.at.6.30.27.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION