fix(dashboard): dashboard doesn't load properly if it has tabs

[stephenLYZ]

SUMMARY

This PR fixes the problem that dashboard does not load properly after switching dashboard when there are tabs and native filters. The reason is that the dashboard is loading the tab component with incorrect timing.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-09-26.1.59.06.mov

after

2022-09-26.1.57.38.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• fixes Dashboard does not load when a filter is configured "Select first filter value by default" option  #20797
• fixes Dashboard shows endless loading #20748
• fixes [Dashboard] Issue with tabbed dashboard #20930
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21576 (d75b932) into master (5d51555) will increase coverage by 0.01%.
The diff coverage is 45.45%.

❗ Current head d75b932 differs from pull request most recent head b9010d4. Consider uploading reports for the commit b9010d4 to get more accurate results

@@            Coverage Diff             @@
##           master   #21576      +/-   ##
==========================================
+ Coverage   66.65%   66.67%   +0.01%     
==========================================
  Files        1794     1794              
  Lines       68692    68701       +9     
  Branches     7308     7313       +5     
==========================================
+ Hits        45789    45807      +18     
+ Misses      21035    21027       -8     
+ Partials     1868     1867       -1     

Flag	Coverage Δ
javascript	52.86% <45.45%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/packages/superset-ui-chart-controls/src/index.ts	100.00% <ø> (ø)
...chart-controls/src/shared-controls/dndControls.tsx	58.33% <ø> (+4.76%)	⬆️
...src/BigNumber/BigNumberWithTrendline/buildQuery.ts	0.00% <0.00%> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx	16.66% <0.00%> (-8.34%)	⬇️
...i-chart-controls/src/shared-controls/constants.tsx	22.22% <20.00%> (-11.12%)	⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx	81.25% <69.23%> (+2.36%)	⬆️
...BigNumber/BigNumberWithTrendline/transformProps.ts	47.05% <75.00%> (+0.79%)	⬆️
...src/dashboard/components/PropertiesModal/index.tsx	67.06% <100.00%> (+5.98%)	⬆️
superset/sql_parse.py	96.49% <0.00%> (-0.59%)	⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

LGTM

[kamalkeshavani-aiinside]

@stephenLYZ I tried 2.0.1rc2 docker hub image, to test this fix. I can still reproduce some issue of tabs. Please check.

[sfirke]

I can confirm that the issue of a dashboard's first (default) tab not loading if there are filters out of scope persists using the 2.0.1rc2 image on docker hub.

[duanzy47]

I still have this issue even with the lastest image 2.0.1rc6, could you please check ? @stephenLYZ

[sfirke]

@duanzy47 this will not be fixed until 2.1.0, see this comment for more #21263 (reply in thread)

[sfirke]

Looks like the issue persists in 2.1.0rc1.