Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless groupby from QueryObject #21643

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Sep 29, 2022

SUMMARY

The groupby isn't a valid QueryObject field so remove this field from 1) Gauge Chart 2) Handlebars Chart. The original chart can work is because the extractQueryFields has converted it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Gauge Chart and Handlebars Chart should work as before.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #21643 (5901370) into master (f3465f5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21643      +/-   ##
==========================================
- Coverage   66.83%   66.83%   -0.01%     
==========================================
  Files        1798     1798              
  Lines       68823    68820       -3     
  Branches     7333     7331       -2     
==========================================
- Hits        45996    45993       -3     
  Misses      20949    20949              
  Partials     1878     1878              
Flag Coverage Δ
javascript 53.16% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/plugin-chart-echarts/src/Gauge/buildQuery.ts 66.66% <ø> (-8.34%) ⬇️
...s/plugin-chart-handlebars/src/plugin/buildQuery.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie force-pushed the refactor/remove_groupby branch from 8bebbb6 to 5901370 Compare September 30, 2022 02:33
@zhaoyongjie zhaoyongjie merged commit 9dd102f into apache:master Sep 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants