-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use queryEditorId in SqlEditor child components #21650
chore: Use queryEditorId in SqlEditor child components #21650
Conversation
# Conflicts: # superset-frontend/src/SqlLab/components/QueryLimitSelect/QueryLimitSelect.test.tsx # superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx # superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx # superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.tsx # superset-frontend/src/SqlLab/components/SaveQuery/index.tsx # superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx # superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx # superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #21650 +/- ##
==========================================
+ Coverage 66.94% 67.00% +0.05%
==========================================
Files 1831 1829 -2
Lines 69833 69798 -35
Branches 7570 7570
==========================================
+ Hits 46749 46767 +18
+ Misses 21126 21073 -53
Partials 1958 1958
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
Code looks great! @jinghua-qa Could you please help with testing SqlLab? |
@michael-s-molina Can also you review the PR? |
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @EugeneTorap.
Code LGTM. We need @jinghua-qa's approval before merging it.
@jinghua-qa @andrey-zayats Can you test the SQL Lab? |
/testenv up |
@jinghua-qa Ephemeral environment spinning up at http://35.87.28.70:8080. Credentials are |
/testenv up |
@jinghua-qa Ephemeral environment spinning up at http://54.202.195.0:8080. Credentials are |
test sqllab regression, LGTM! |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Fix potential re-rendering in SqlEditor child components.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION