Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): Range filter max/min default display value #21680

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Oct 3, 2022

SUMMARY

When user added a range native filter with single value option (minimum or maximum) and a default value, the default value would be displayed incorrectly (even though the filter applied correct values). This PR fixes that behaviour

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-08-24.at.4.56.43.PM.mov

After:

Screen.Recording.2022-10-03.at.15.32.18.mov

TESTING INSTRUCTIONS

  1. Create a range native filter, select single value minimum or maximum and a default value
  2. Verify that the filter in the filter bar displays with correct default range
  3. Verify that filter is applied correctly to charts

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this high impact bug! Note to self: this filter could potentially do with some refactoring at some point, as it's slightly difficult to grasp without going very deep into the logic.

@kgabryje
Copy link
Member Author

kgabryje commented Oct 4, 2022

LGTM, thanks for fixing this high impact bug! Note to self: this filter could potentially do with some refactoring at some point, as it's slightly difficult to grasp without going very deep into the logic.

I think that's true for a big chunk of the native filters codebase 😄

@kgabryje kgabryje merged commit f784455 into apache:master Oct 4, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants