Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: E2E tests for Drill to Detail supported Charts #21681

Merged
merged 11 commits into from
Oct 5, 2022
Merged

chore: E2E tests for Drill to Detail supported Charts #21681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
045dda2
Merge branch 'master' of https://github.com/apache/superset into chor…
geido Sep 30, 2022
afbd997
Add tests Tier1 and Tier2
geido Sep 30, 2022
371a47f
Enhance tests
geido Oct 3, 2022
79444c5
Fix tests
geido Oct 3, 2022
a7399b0
Merge branch 'master' of https://github.com/apache/superset into chor…
geido Oct 3, 2022
252a232
Merge branch 'master' of https://github.com/apache/superset into chor…
geido Oct 4, 2022
c0d7a2b
Update failing tests
geido Oct 4, 2022
060c257
Remove flaky test
geido Oct 4, 2022
5571142
Lint
geido Oct 4, 2022
03886f9
Enhance test
geido Oct 4, 2022
bb484d0
Use mousemove
geido Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed ...-frontend/cypress-base/cypress/downloads/new-chart-2022-09-09T14-22-31.728Z.jpg
View file
Open in desktop
Binary file not shown.
410 changes: 350 additions & 60 deletions superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function visitDashboard() {
cy.wait('@get');
cy.wait('@getCharts');
cy.wait('@getDatasets');
cy.wait(500);
cy.url().should('contain', 'native_filters_key');
}

function prepareDashboardFilters(
Expand Down Expand Up @@ -454,6 +454,7 @@ describe('Native filters', () => {
let filterKey: string;
const removeFirstChar = (search: string) =>
search.split('').slice(1, search.length).join('');

cy.location().then(loc => {
const queryParams = qs.parse(removeFirstChar(loc.search));
filterKey = queryParams.native_filters_key as string;
Expand Down
12 changes: 7 additions & 5 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/area.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@
* under the License.
*/
describe('Visualization > Area', () => {
beforeEach(() => {
cy.preserveLogin();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

const AREA_FORM_DATA = {
datasource: '2__table',
viz_type: 'area',
Expand Down Expand Up @@ -55,11 +60,6 @@ describe('Visualization > Area', () => {
cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
}

beforeEach(() => {
cy.login();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

it('should work without groupby', () => {
verify(AREA_FORM_DATA);
cy.get('.nv-area').should('have.length', 1);
Expand Down Expand Up @@ -105,6 +105,8 @@ describe('Visualization > Area', () => {
});

it('should allow type to search color schemes and apply the scheme', () => {
verify(AREA_FORM_DATA);

cy.get('#controlSections-tab-display').click();
cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
cy.get('.Control[data-test="color_scheme"] input[type="search"]')
Expand Down
10 changes: 5 additions & 5 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/big_number.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
import { interceptChart } from 'cypress/utils';

describe('Visualization > Big Number with Trendline', () => {
beforeEach(() => {
cy.preserveLogin();
interceptChart({ legacy: false }).as('chartData');
});

const BIG_NUMBER_FORM_DATA = {
datasource: '2__table',
viz_type: 'big_number',
Expand Down Expand Up @@ -49,11 +54,6 @@ describe('Visualization > Big Number with Trendline', () => {
});
}

beforeEach(() => {
cy.login();
interceptChart({ legacy: false }).as('chartData');
});

it('should work', () => {
verify(BIG_NUMBER_FORM_DATA);
cy.get('.chart-container .header-line');
Expand Down
10 changes: 5 additions & 5 deletions ...frontend/cypress-base/cypress/integration/explore/visualizations/big_number_total.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,16 @@ import { interceptChart } from 'cypress/utils';
import { FORM_DATA_DEFAULTS, NUM_METRIC } from './shared.helper';

describe('Visualization > Big Number Total', () => {
beforeEach(() => {
cy.preserveLogin();
interceptChart({ legacy: false }).as('chartData');
});

const BIG_NUMBER_DEFAULTS = {
...FORM_DATA_DEFAULTS,
viz_type: 'big_number_total',
};

beforeEach(() => {
cy.login();
interceptChart({ legacy: false }).as('chartData');
});

it('Test big number chart with adhoc metric', () => {
const formData = { ...BIG_NUMBER_DEFAULTS, metric: NUM_METRIC };

Expand Down
12 changes: 7 additions & 5 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/box_plot.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@
* under the License.
*/
describe('Visualization > Box Plot', () => {
beforeEach(() => {
cy.preserveLogin();
cy.intercept('POST', '/api/v1/chart/data*').as('getJson');
});

const BOX_PLOT_FORM_DATA = {
datasource: '2__table',
viz_type: 'box_plot',
Expand All @@ -37,17 +42,14 @@ describe('Visualization > Box Plot', () => {
cy.verifySliceSuccess({ waitAlias: '@getJson' });
}

beforeEach(() => {
cy.login();
cy.intercept('POST', '/api/v1/chart/data*').as('getJson');
});

it('should work', () => {
verify(BOX_PLOT_FORM_DATA);
cy.get('.chart-container .box_plot canvas').should('have.length', 1);
});

it('should allow type to search color schemes', () => {
verify(BOX_PLOT_FORM_DATA);

cy.get('#controlSections-tab-display').click();
cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
cy.get('.Control[data-test="color_scheme"] input[type="search"]')
Expand Down
34 changes: 7 additions & 27 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/bubble.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@
* under the License.
*/
describe('Visualization > Bubble', () => {
beforeEach(() => {
cy.preserveLogin();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

const BUBBLE_FORM_DATA = {
datasource: '2__table',
viz_type: 'bubble',
Expand Down Expand Up @@ -51,33 +56,6 @@ describe('Visualization > Bubble', () => {
cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
}

beforeEach(() => {
cy.login();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

// Number of circles are pretty unstable when there are a lot of circles
// Since main functionality is already covered in filter test below,
// skip this test until we find a solution.
it.skip('should work', () => {
cy.visitChartByParams(BUBBLE_FORM_DATA).then(() => {
cy.wait('@getJson').then(xhr => {
let expectedBubblesNumber = 0;
xhr.responseBody.data.forEach(element => {
expectedBubblesNumber += element.values.length;
});
cy.get('[data-test="chart-container"]')
.should('be.visible', { timeout: 15000 })
.within(() => {
cy.get('svg')
.should('exist')
.find('.nv-point-clips circle')
.should('have.length', expectedBubblesNumber);
});
});
});
});

it('should work with filter', () => {
verify({
...BUBBLE_FORM_DATA,
Expand Down Expand Up @@ -109,6 +87,8 @@ describe('Visualization > Bubble', () => {
});

it('should allow type to search color schemes and apply the scheme', () => {
cy.visitChartByParams(BUBBLE_FORM_DATA);

cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
cy.get('.Control[data-test="color_scheme"] input[type="search"]')
.focus()
Expand Down
12 changes: 7 additions & 5 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/compare.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@
* under the License.
*/
describe('Visualization > Compare', () => {
beforeEach(() => {
cy.preserveLogin();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

const COMPARE_FORM_DATA = {
datasource: '3__table',
viz_type: 'compare',
Expand Down Expand Up @@ -51,11 +56,6 @@ describe('Visualization > Compare', () => {
cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
}

beforeEach(() => {
cy.login();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

it('should work without groupby', () => {
verify(COMPARE_FORM_DATA);
cy.get('.chart-container .nvd3 path.nv-line').should('have.length', 1);
Expand Down Expand Up @@ -88,6 +88,8 @@ describe('Visualization > Compare', () => {
});

it('should allow type to search color schemes and apply the scheme', () => {
verify(COMPARE_FORM_DATA);

cy.get('#controlSections-tab-display').click();
cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
cy.get('.Control[data-test="color_scheme"] input[type="search"]')
Expand Down
21 changes: 11 additions & 10 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/dist_bar.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,20 @@
import { FORM_DATA_DEFAULTS, NUM_METRIC } from './shared.helper';

describe('Visualization > Distribution bar chart', () => {
const VIZ_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'dist_bar' };

beforeEach(() => {
cy.login();
cy.preserveLogin();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

it('should work with adhoc metric', () => {
const formData = {
...VIZ_DEFAULTS,
metrics: NUM_METRIC,
groupby: ['state'],
};
const VIZ_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'dist_bar' };
const DISTBAR_FORM_DATA = {
...VIZ_DEFAULTS,
metrics: NUM_METRIC,
groupby: ['state'],
};

cy.visitChartByParams(formData);
it('should work with adhoc metric', () => {
cy.visitChartByParams(DISTBAR_FORM_DATA);
cy.verifySliceSuccess({
waitAlias: '@getJson',
querySubstring: NUM_METRIC.label,
Expand Down Expand Up @@ -79,6 +78,8 @@ describe('Visualization > Distribution bar chart', () => {
});

it('should allow type to search color schemes and apply the scheme', () => {
cy.visitChartByParams(DISTBAR_FORM_DATA);

cy.get('#controlSections-tab-display').click();
cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
cy.get('.Control[data-test="color_scheme"] input[type="search"]')
Expand Down
12 changes: 7 additions & 5 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/dual_line.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@
* under the License.
*/
describe('Visualization > Dual Line', () => {
beforeEach(() => {
cy.preserveLogin();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

const DUAL_LINE_FORM_DATA = {
datasource: '3__table',
viz_type: 'dual_line',
Expand All @@ -39,11 +44,6 @@ describe('Visualization > Dual Line', () => {
cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
}

beforeEach(() => {
cy.login();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

it('should work', () => {
verify(DUAL_LINE_FORM_DATA);
cy.get('.chart-container svg path.nv-line').should('have.length', 2);
Expand All @@ -68,6 +68,8 @@ describe('Visualization > Dual Line', () => {
});

it('should allow type to search color schemes and apply the scheme', () => {
verify(DUAL_LINE_FORM_DATA);

cy.get('#controlSections-tab-display').click();
cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
cy.get('.Control[data-test="color_scheme"] input[type="search"]')
Expand Down
19 changes: 10 additions & 9 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/gauge.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,18 @@
* under the License.
*/

// TODO(kgabryje): fix it and un-skip
describe.skip('Visualization > Gauge', () => {
describe('Visualization > Gauge', () => {
beforeEach(() => {
cy.preserveLogin();
cy.intercept('POST', '/api/v1/chart/data*').as('getJson');
});

const GAUGE_FORM_DATA = {
datasource: '2__table',
datasource: '3__table',
viz_type: 'gauge_chart',
metric: 'count',
adhoc_filters: [],
slice_id: 49,
slice_id: 54,
row_limit: 10,
};

Expand All @@ -33,11 +37,6 @@ describe.skip('Visualization > Gauge', () => {
cy.verifySliceSuccess({ waitAlias: '@getJson' });
}

beforeEach(() => {
cy.login();
cy.intercept('POST', '/api/v1/chart/data*').as('getJson');
});

it('should work', () => {
verify(GAUGE_FORM_DATA);
cy.get('.chart-container .gauge_chart canvas').should('have.length', 1);
Expand All @@ -64,6 +63,8 @@ describe.skip('Visualization > Gauge', () => {
});

it('should allow type to search color schemes', () => {
verify(GAUGE_FORM_DATA);

cy.get('#controlSections-tab-display').click();
cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
cy.get('.Control[data-test="color_scheme"] input[type="search"]')
Expand Down
12 changes: 7 additions & 5 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/graph.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ type adhocFilter = {
};

describe('Visualization > Graph', () => {
beforeEach(() => {
cy.preserveLogin();
cy.intercept('POST', '/api/v1/chart/data*').as('getJson');
});

const GRAPH_FORM_DATA = {
datasource: '1__table',
viz_type: 'graph_chart',
Expand All @@ -50,11 +55,6 @@ describe('Visualization > Graph', () => {
cy.verifySliceSuccess({ waitAlias: '@getJson' });
}

beforeEach(() => {
cy.login();
cy.intercept('POST', '/api/v1/chart/data*').as('getJson');
});

it('should work with ad-hoc metric', () => {
verify(GRAPH_FORM_DATA);
cy.get('.chart-container .graph_chart canvas').should('have.length', 1);
Expand All @@ -79,6 +79,8 @@ describe('Visualization > Graph', () => {
});

it('should allow type to search color schemes', () => {
verify(GRAPH_FORM_DATA);

cy.get('#controlSections-tab-display').click();
cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
cy.get('.Control[data-test="color_scheme"] input[type="search"]')
Expand Down
12 changes: 7 additions & 5 deletions superset-frontend/cypress-base/cypress/integration/explore/visualizations/histogram.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
import { QueryFormData } from '@superset-ui/core';

describe('Visualization > Histogram', () => {
beforeEach(() => {
cy.preserveLogin();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

const HISTOGRAM_FORM_DATA: QueryFormData = {
datasource: '3__table',
viz_type: 'histogram',
Expand All @@ -43,11 +48,6 @@ describe('Visualization > Histogram', () => {
cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
}

beforeEach(() => {
cy.login();
cy.intercept('POST', '/superset/explore_json/**').as('getJson');
});

it('should work without groupby', () => {
verify(HISTOGRAM_FORM_DATA);
cy.get('.chart-container svg .vx-bar').should(
Expand Down Expand Up @@ -86,6 +86,8 @@ describe('Visualization > Histogram', () => {
});

it('should allow type to search color schemes and apply the scheme', () => {
verify(HISTOGRAM_FORM_DATA);

cy.get('#controlSections-tab-display').click();
cy.get('.Control[data-test="color_scheme"]').scrollIntoView();
cy.get('.Control[data-test="color_scheme"] input[type="search"]')
Expand Down
Loading