Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Right-click on a chart's null values #21706

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a bug when right-clicking on a chart's null values.

@codyml

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-10-05.at.2.23.52.PM.mov
Screen.Recording.2022-10-05.at.2.19.51.PM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #21706 (b5aac09) into master (2907869) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21706      +/-   ##
==========================================
- Coverage   66.84%   66.83%   -0.01%     
==========================================
  Files        1799     1799              
  Lines       68870    68889      +19     
  Branches     7314     7328      +14     
==========================================
+ Hits        46034    46043       +9     
- Misses      20954    20959       +5     
- Partials     1882     1887       +5     
Flag Coverage Δ
javascript 53.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <0.00%> (ø)
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Treemap/EchartsTreemap.tsx 0.00% <0.00%> (ø)
...ns/plugin-chart-echarts/src/utils/eventHandlers.ts 0.00% <0.00%> (ø)
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)
...tend/plugins/plugin-chart-table/src/TableChart.tsx 45.94% <0.00%> (-0.51%) ⬇️
.../src/dashboard/components/DrillDetailPane/utils.ts 57.14% <ø> (ø)
superset-frontend/src/preamble.ts 44.00% <0.00%> (-2.16%) ⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx 69.73% <0.00%> (-1.89%) ⬇️
...frontend/src/components/DatabaseSelector/index.tsx 92.42% <0.00%> (-1.52%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie self-requested a review October 6, 2022 00:44
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michael-s-molina, Thanks for the fix. from the error logging, I think it was a backend-side validation error. the Marshmallow validation might need to support null value validation. I will check this logic today.

@zhaoyongjie
Copy link
Member

zhaoyongjie commented Oct 6, 2022

Open a PR to fix this.

@michael-s-molina
Copy link
Member Author

Closing this in favor of #21713.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants