Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: categorical x-axis can't apply the label of column #21869

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Oct 19, 2022

SUMMARY

This PR intends to fix that the categorical x-axis can't correct to render. This issue is caused by not getting the the label of column.

When I fix this issue, I found another issue in the Adhoc Column control is that the query result can't apply the label of column (alias in the SQL) as well, but this issue requires extensive refactoring, which is beyond the scope of this PR.

image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

Before

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie marked this pull request as ready for review October 19, 2022 09:30
@zhaoyongjie zhaoyongjie requested a review from villebro October 19, 2022 09:52
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #21869 (7237907) into master (0a4ecca) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

❗ Current head 7237907 differs from pull request most recent head d5569c6. Consider uploading reports for the commit d5569c6 to get more accurate results

@@            Coverage Diff             @@
##           master   #21869      +/-   ##
==========================================
- Coverage   66.92%   66.92%   -0.01%     
==========================================
  Files        1805     1805              
  Lines       69079    69085       +6     
  Branches     7379     7383       +4     
==========================================
  Hits        46233    46233              
- Misses      20940    20944       +4     
- Partials     1906     1908       +2     
Flag Coverage Δ
javascript 53.32% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 51.72% <40.00%> (-1.85%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie merged commit 9aa804e into apache:master Oct 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants