Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Percent of previous' to sunburst vis. Appease npm warnings for data tables and d3.layout.cloud #219

Merged
merged 2 commits into from
Apr 1, 2016

Conversation

williaster
Copy link
Contributor

Requested by Dan Frank, agree it's useful to know the % of total (what was there previously) as well as the % of previous step when doing path analysis.

@mistercrunch @michellethomas

screen shot 2016-03-31 at 10 59 24 am

screen shot 2016-03-31 at 10 59 02 am

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 6ef0f94 on airbnb:chris/sunburst-conditional-percent into bd9051a on airbnb:master.

@mistercrunch
Copy link
Member

what about "parent" instead of "previous"?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.139% when pulling 6ef0f94 on chris/sunburst-conditional-percent into bd9051a on master.

@williaster
Copy link
Contributor Author

👍 I called it parent in the code ... totally agree.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling c542b1f on airbnb:chris/sunburst-conditional-percent into bd9051a on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.139% when pulling c542b1f on chris/sunburst-conditional-percent into bd9051a on master.

@mistercrunch
Copy link
Member

Oh looks like you need to rebase...

@williaster williaster force-pushed the chris/sunburst-conditional-percent branch from c542b1f to b87d8a0 Compare March 31, 2016 22:46
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling b87d8a0 on airbnb:chris/sunburst-conditional-percent into 167fb64 on airbnb:master.

@williaster
Copy link
Contributor Author

done.

@mistercrunch
Copy link
Member

👍

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants