-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: time grain key from P0.25Y to P3M #21919
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21919 +/- ##
===========================================
+ Coverage 55.55% 66.66% +11.11%
===========================================
Files 1806 1806
Lines 69140 69141 +1
Branches 7393 7393
===========================================
+ Hits 38409 46096 +7687
+ Misses 28822 21136 -7686
Partials 1909 1909
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll try to keep this in mind when reviewing new db engine specs in the future.
SUMMARY
The quarter identifier is
P3M
in the time grains instead ofP0.25Y
. This PR intends to fix this case in DuckDB, Tera Data, and Kusto.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION