Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure data cleanup in Cypress #21921

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

geido
Copy link
Member

@geido geido commented Oct 24, 2022

SUMMARY

As reported in this PR sample data could be hanging between parallel Cypress runs. These changes ensure that all sample data is cleaned up before every test.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #21921 (d22465d) into master (7edf1fb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21921   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files        1807     1807           
  Lines       69142    69142           
  Branches     7394     7394           
=======================================
  Hits        46269    46269           
  Misses      20963    20963           
  Partials     1910     1910           
Flag Coverage Δ
hive 52.92% <ø> (ø)
javascript 53.33% <ø> (ø)
mysql 78.35% <ø> (ø)
postgres 78.41% <ø> (ø)
presto 52.82% <ø> (ø)
python 81.47% <ø> (ø)
sqlite 76.90% <ø> (ø)
unit 51.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the stability/cleanup!

@geido geido added the need:qa-review Requires QA review label Oct 24, 2022
Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit a36ab71 into master Oct 24, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix/cypress-parallelization branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants