Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(translations): French translation (typo fixes) #21942

Merged
merged 1 commit into from
Dec 9, 2022
Merged

fix(translations): French translation (typo fixes) #21942

merged 1 commit into from
Dec 9, 2022

Conversation

xavier-GitHub76
Copy link
Contributor

Hello,
it's my first commit.
I just corrected some typos.
Best regards

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@xavier-GitHub76
Fix French translation (typo fixes)
c1af820 
Hello,
it's my first commit.
I just corrected some typos.
Best regards
@rusackas rusackas requested a review from mistercrunch December 7, 2022 23:34
lyndsiWilliams
lyndsiWilliams approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to check these typos in Google Translate and they all look good, thanks for the fixes!
image

@rusackas
Copy link
Member

rusackas commented Dec 9, 2022

Closing and re-opening to kick CI into gear 🤞

@rusackas rusackas closed this Dec 9, 2022
@rusackas rusackas reopened this Dec 9, 2022
@rusackas rusackas changed the title Fix French translation (typo fixes) fix(translations): French translation (typo fixes) Dec 9, 2022
@rusackas
Copy link
Member

rusackas commented Dec 9, 2022

Thanks for the contribution @xavier-GitHub76! Please reach out on Slack if you ever want to talk about working on additional PRs!

@rusackas rusackas merged commit a993c3c into apache:master Dec 9, 2022
This was referenced Jan 3, 2023
Merged
Merged
@xavier-GitHub76
Copy link
Contributor Author

Hello,
the commit was merge but the translation is not present in superset V3
image

@xavier-GitHub76
Copy link
Contributor Author

"Schedule a new email report" should be added to https://github.com/apache/superset/tree/3.0/superset/translations/fr/LC_MESSAGES
/messages.json
"Scheduled task executor not found" should be added to https://github.com/apache/superset/tree/3.0/superset/translations/fr/LC_MESSAGES
/messages.json

@xavier-GitHub76
Copy link
Contributor Author

I update the LC_MESSAGES (#25873)

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyndsiWilliams lyndsiWilliams lyndsiWilliams approved these changes

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xavier-GitHub76 @rusackas @lyndsiWilliams @mistercrunch