Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename datasource->dataset in error message #21959

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

mistercrunch
Copy link
Member

Looks like we missed that one on wider renaming effort.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #21959 (546d2a1) into master (7e3e133) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21959   +/-   ##
=======================================
  Coverage   66.94%   66.95%           
=======================================
  Files        1807     1807           
  Lines       69210    69210           
  Branches     7399     7399           
=======================================
+ Hits        46335    46338    +3     
+ Misses      20966    20963    -3     
  Partials     1909     1909           
Flag Coverage Δ
hive 52.92% <ø> (ø)
mysql 78.36% <ø> (ø)
postgres 78.43% <ø> (+<0.01%) ⬆️
presto 52.82% <ø> (ø)
python 81.48% <ø> (+<0.01%) ⬆️
sqlite 76.91% <ø> (ø)
unit 51.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/query_context_processor.py 88.51% <ø> (ø)
superset/common/query_object.py 94.38% <0.00%> (+0.51%) ⬆️
superset/commands/importers/v1/utils.py 93.50% <0.00%> (+1.29%) ⬆️
superset/reports/commands/log_prune.py 89.28% <0.00%> (+3.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie self-requested a review October 28, 2022 05:17
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenLYZ stephenLYZ merged commit 72598a5 into apache:master Nov 1, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants