refactor: use exception status for logging #21971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
force-pushed
the
elizabeth/celery-logs-2
branch
2 times, most recently
from
5886783
to
d01ef03
Compare
eschutho
changed the title
Codecov Report
@@ Coverage Diff @@
## master #21971 +/- ##
==========================================
+ Coverage 65.56% 66.99% +1.42%
==========================================
Files 1815 1815
Lines 69553 69623 +70
Branches 7486 7486
==========================================
+ Hits 45604 46642 +1038
+ Misses 22015 21047 -968
Partials 1934 1934
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
force-pushed
the
elizabeth/celery-logs-2
branch
3 times, most recently
from
dd002fc
to
357dab2
Compare
eschutho
changed the title
eschutho
force-pushed
the
elizabeth/celery-logs-2
branch
from
357dab2
to
ec6025a
Compare
eschutho
force-pushed
the
elizabeth/celery-logs-2
branch
from
ec6025a
to
baa3c26
Compare
AAfghahi
approved these changes
Nov 14, 2022
hughhhh
reviewed
Nov 14, 2022
| @@ -258,6 +261,17 @@ class ReportScheduleStateNotFoundError(CommandException): | |||
| message = _("Report Schedule state not found") | |||
|
|
|||
|
|
|||
| class ReportScheduleSystemErrorsException(CommandException, SupersetErrorsException): | |||
| errors: List[SupersetError] = [] | |||
There was a problem hiding this comment.
Do we want to set an overall status for the array or do we want to do it based upon the most critical error in the error array
There was a problem hiding this comment.
we set the status based upon the most critical
|
|
||
|
|
||
| class ReportScheduleClientErrorsException(CommandException, SupersetErrorsException): | ||
| status = 400 |
There was a problem hiding this comment.
Here we have a status but the exception above doesn't
AnushaErrabelli
pushed a commit
to preset-io/superset
that referenced
this pull request
Nov 15, 2022
(cherry picked from commit ce145c6)
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Followup to #21627
In order to be able to log celery errors and warnings separately, I am focusing on report errors for both slack and email and raising either a ReportScheduleClientErrorsException or ReportScheduleSystemErrorsException and then logging according to the status code of each (4xx or 500).
For slack errors, I am also catching each error from the slack api and raising an appropriate http status code, which then helps to inform the logging level for celery.
ADDITIONAL INFORMATION