Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Add edit button to filter fashboard cards #21985

Closed
wants to merge 3 commits into from

Conversation

agl-developer
Copy link
Contributor

Add an option to jump directly to editing the selected filter in the dashboard view

SUMMARY

Add an edit button in the form of an icon to quickly edit the selected filter.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Add filter edit button

TESTING INSTRUCTIONS

  • It should only appear for admin user
  • Clicking opens filters config modal and selects current filter for editing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Add an option to jump directly to editing the selected filter in the dashboard view
@agl-developer agl-developer changed the title Add edit button to filter fashboard cards feat(dashboard) - Add edit button to filter fashboard cards Oct 31, 2022
@agl-developer agl-developer changed the title feat(dashboard) - Add edit button to filter fashboard cards feat(dashboard): Add edit button to filter fashboard cards Oct 31, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #21985 (2966c09) into master (5c27aaf) will decrease coverage by 0.00%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master   #21985      +/-   ##
==========================================
- Coverage   67.00%   67.00%   -0.01%     
==========================================
  Files        1809     1809              
  Lines       69295    69304       +9     
  Branches     7410     7411       +1     
==========================================
+ Hits        46430    46434       +4     
- Misses      20955    20959       +4     
- Partials     1910     1911       +1     
Flag Coverage Δ
javascript 53.41% <53.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ilters/FilterBar/FilterConfigurationLink/index.tsx 85.71% <0.00%> (-14.29%) ⬇️
...oard/components/nativeFilters/FilterCard/index.tsx 8.33% <0.00%> (-1.67%) ⬇️
...rd/components/nativeFilters/FilterCard/NameRow.tsx 80.00% <66.66%> (-5.72%) ⬇️
...nts/nativeFilters/FilterCard/FilterCardContent.tsx 100.00% <100.00%> (ø)
...oard/components/nativeFilters/FilterCard/Styles.ts 82.35% <100.00%> (+2.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido
Copy link
Member

geido commented Nov 1, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

@geido Ephemeral environment spinning up at http://18.236.198.33:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@villebro
Copy link
Member

villebro commented Nov 1, 2022

@agl-developer hey this is really nice! @kasiazjc any thoughts on the design here?

@kgabryje
Copy link
Member

kgabryje commented Nov 4, 2022

CC @codyml for review

@codyml
Copy link
Member

codyml commented Dec 7, 2022

Work on this feature has been moved to #22364; if a committer could close this PR that would be great.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants