chore: Verify edit permission for Horizontal filter bar

[geido]

SUMMARY

Verifies wether the user can edit in order to show the horizontal/vertical filter bar display options

FILTER BAR DISPLAY OPTIONS

TESTING INSTRUCTIONS

1. Open a Dashboard for which you don't have permissions, the gear icon should not appear
2. Open a Dashboard for which yo have permissions, the gear icon should appear

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21990 (b4f27c7) into master (dc73995) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21990      +/-   ##
==========================================
- Coverage   66.99%   66.97%   -0.03%     
==========================================
  Files        1809     1809              
  Lines       69324    69335      +11     
  Branches     7410     7414       +4     
==========================================
- Hits        46443    46434       -9     
- Misses      20971    20990      +19     
- Partials     1910     1911       +1     

Flag	Coverage Δ
hive	52.90% <ø> (ø)
javascript	53.41% <100.00%> (-0.01%)	⬇️
mysql	?
postgres	78.42% <ø> (ø)
presto	52.80% <ø> (ø)
python	81.48% <ø> (-0.05%)	⬇️
sqlite	76.90% <ø> (ø)
unit	51.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...omponents/nativeFilters/FilterBar/Header/index.tsx	91.30% <100.00%> (ø)
superset/common/utils/dataframe_utils.py	90.47% <0.00%> (-4.77%)	⬇️
superset/db_engine_specs/mysql.py	94.04% <0.00%> (-4.77%)	⬇️
...et-frontend/src/components/TableSelector/index.tsx	77.63% <0.00%> (-1.04%)	⬇️
superset/models/core.py	89.58% <0.00%> (-0.70%)	⬇️
superset/views/core.py	75.51% <0.00%> (-0.46%)	⬇️
superset-frontend/src/explore/ExplorePage.tsx	0.00% <0.00%> (ø)
...frontend/src/components/DatabaseSelector/index.tsx	92.53% <0.00%> (+0.11%)	⬆️
...uperset-frontend/src/utils/getClientErrorObject.ts	60.86% <0.00%> (+2.33%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kgabryje]

LGTM

[villebro]

@geido regarding the wording here, I wonder if "Orientation of filter bar" would be more appropriate with the current options (Vertical or Horizontal)? It feels like "Placement" refers to Left or Top, while "Orientation" refers to Vertical or Horizontal..

[geido]

@geido regarding the wording here, I wonder if "Orientation of filter bar" would be more appropriate with the current options (Vertical or Horizontal)? It feels like "Placement" refers to Left or Top, while "Orientation" refers to Vertical or Horizontal..

@villebro that's a nice catch! I'll propose this change and open a sep PR