[deprecate_v1] Change filter endpoint to match with new url format #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vera-liu
changed the title
superset/views.py
Outdated
| @@ -1693,33 +1693,32 @@ def filter(self, datasource_type, datasource_id, column): | |||
| :return: | |||
| """ | |||
| # TODO: Cache endpoint by user, datasource and column | |||
| form_data=self.get_form_data() | |||
There was a problem hiding this comment.
Missing whitespace around operator
vera-liu
force-pushed
the
vliu_filter_endpoint
branch
from
e0fc8b2 to
1f15b5d
Compare
vera-liu
force-pushed
the
vliu_filter_endpoint
branch
from
1f15b5d to
57b1455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
@mistercrunch