-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 3 new extension points for inserting custom icons #22027
Conversation
{DropdownItemExtension ? ( | ||
<StyledDropdownItemWithIcon> | ||
<div>{t('Set up an email report')}</div> | ||
<DropdownItemExtension /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to be this specific, or could we use an extension for the whole item, passing down the text instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure here. On one hand having the extension be a whole replacement would allow for much more flexibility for anyone looking to use it. On the other hand, having it be specific provides one rigid supported pattern for the extension, which could be seen as a benefit.
Codecov Report
@@ Coverage Diff @@
## master #22027 +/- ##
========================================
Coverage 66.90% 66.91%
========================================
Files 1807 1813 +6
Lines 69183 69406 +223
Branches 7405 7482 +77
========================================
+ Hits 46288 46444 +156
- Misses 20985 21029 +44
- Partials 1910 1933 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SUMMARY
Preset would like to include custom icons in these three components. This PR introduces three new keys to the extensions registry to support this.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION