Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 3 new extension points for inserting custom icons #22027

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

jfrag1
Copy link
Member

@jfrag1 jfrag1 commented Nov 3, 2022

SUMMARY

Preset would like to include custom icons in these three components. This PR introduces three new keys to the extensions registry to support this.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-11-03 at 8 38 17 AM

Screen Shot 2022-11-03 at 8 38 35 AM

Screen Shot 2022-11-03 at 8 39 22 AM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 3, 2022
{DropdownItemExtension ? (
<StyledDropdownItemWithIcon>
<div>{t('Set up an email report')}</div>
<DropdownItemExtension />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to be this specific, or could we use an extension for the whole item, passing down the text instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure here. On one hand having the extension be a whole replacement would allow for much more flexibility for anyone looking to use it. On the other hand, having it be specific provides one rigid supported pattern for the extension, which could be seen as a benefit.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #22027 (b8f0160) into master (792820e) will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@           Coverage Diff            @@
##           master   #22027    +/-   ##
========================================
  Coverage   66.90%   66.91%            
========================================
  Files        1807     1813     +6     
  Lines       69183    69406   +223     
  Branches     7405     7482    +77     
========================================
+ Hits        46288    46444   +156     
- Misses      20985    21029    +44     
- Partials     1910     1933    +23     
Flag Coverage Δ
javascript 53.46% <60.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...perset-frontend/src/views/components/RightMenu.tsx 78.23% <50.00%> (-0.25%) ⬇️
...ponents/ReportModal/HeaderReportDropdown/index.tsx 67.50% <60.00%> (-0.50%) ⬇️
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 59.64% <66.66%> (+0.01%) ⬆️
superset-frontend/src/components/Select/styles.tsx 81.81% <0.00%> (-18.19%) ⬇️
...t-ui-chart-controls/src/shared-controls/mixins.tsx 16.66% <0.00%> (-16.67%) ⬇️
...perset-ui-chart-controls/src/sections/sections.tsx 71.42% <0.00%> (-16.08%) ⬇️
...ashboard/components/BuilderComponentPane/index.tsx 66.66% <0.00%> (-9.81%) ⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 62.73% <0.00%> (-6.29%) ⬇️
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 49.03% <0.00%> (-5.67%) ⬇️
... and 84 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lilykuang lilykuang merged commit c870fbe into apache:master Nov 4, 2022
@lilykuang lilykuang deleted the jack/icon-extensions branch November 4, 2022 18:54
jfrag1 added a commit to preset-io/superset that referenced this pull request Nov 7, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants