Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix act errors in DndColumnSelectControl tests #22068

Merged
merged 1 commit into from
Nov 8, 2022
Merged

test: Fix act errors in DndColumnSelectControl tests #22068

merged 1 commit into from
Nov 8, 2022

Conversation

corbinrobb
Copy link
Contributor

SUMMARY

Cleans up a few act errors in

  • superset-frontend/src/explore/components/controls/DndColumnSelectControl/OptionWrapper.test.tsx
  • superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.test.tsx

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  • cd into /superset-frontend
  • npm run test -- src/explore/components/controls/DndColumnSelectControl/Option.test.tsx
  • npm run test -- src/explore/components/controls/DndColumnSelectControl/OptionWrapper.test.tsx
  • Check for act errors

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

lyndsiWilliams
lyndsiWilliams approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this branch down locally and ran the tests, no act errors remain. 8 act errors squashed on this one, thanks Corbin! 😁

@michael-s-molina michael-s-molina merged commit cdec092 into apache:master Nov 8, 2022
@eschutho
Copy link
Member

eschutho commented Nov 8, 2022

Welcome back @corbinrobb!!!

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@lyndsiWilliams lyndsiWilliams lyndsiWilliams approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corbinrobb @eschutho @lyndsiWilliams @michael-s-molina @mistercrunch