fix: chart id mapping in dashboard api

[villebro]

SUMMARY

The result payload of the /api/v1/dashboard/<pk>/charts endpoint is currently missing the chart's id due to the field being mapped incorrectly to slice_id (it's id in the model). This fixes the error and adds a description to the id field.

AFTER

Now the playload contains the id of the chart in accordance with the OpenAPI spec:

BEFORE

Previously the id was missing due to incorrectly being referenced as slice_id:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[dpgaspar]

Nice, add a test to make sure all expected fields are returned

[codecov]

Codecov Report

Merging #22179 (da0a669) into master (2e5270c) will decrease coverage by 1.46%.
The diff coverage is 100.00%.

❗ Current head da0a669 differs from pull request most recent head eb71a42. Consider uploading reports for the commit eb71a42 to get more accurate results

@@            Coverage Diff             @@
##           master   #22179      +/-   ##
==========================================
- Coverage   67.00%   65.53%   -1.47%     
==========================================
  Files        1835     1835              
  Lines       69970    69971       +1     
  Branches     7590     7590              
==========================================
- Hits        46880    45857    -1023     
- Misses      21124    22148    +1024     
  Partials     1966     1966              

Flag	Coverage Δ
hive	?
mysql	78.14% <100.00%> (+<0.01%)	⬆️
postgres	78.21% <100.00%> (+<0.01%)	⬆️
presto	?
python	78.33% <100.00%> (-3.06%)	⬇️
sqlite	76.66% <100.00%> (+<0.01%)	⬆️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/charts/schemas.py	99.35% <100.00%> (+<0.01%)	⬆️
superset/db_engines/hive.py	0.00% <0.00%> (-85.19%)	⬇️
...set/advanced_data_type/plugins/internet_address.py	16.32% <0.00%> (-79.60%)	⬇️
superset/utils/pandas_postprocessing/boxplot.py	20.51% <0.00%> (-79.49%)	⬇️
superset/charts/post_processing.py	11.76% <0.00%> (-77.95%)	⬇️
...perset/advanced_data_type/plugins/internet_port.py	18.75% <0.00%> (-77.09%)	⬇️
superset/utils/pandas_postprocessing/rolling.py	21.87% <0.00%> (-68.75%)	⬇️
...perset/utils/pandas_postprocessing/contribution.py	34.61% <0.00%> (-65.39%)	⬇️
superset/utils/pandas_postprocessing/resample.py	37.50% <0.00%> (-62.50%)	⬇️
superset/utils/pandas_postprocessing/select.py	38.46% <0.00%> (-61.54%)	⬇️
... and 57 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more