-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Display Error Messages in DB Connection Modal #22200
fix: Display Error Messages in DB Connection Modal #22200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22200 +/- ##
===========================================
+ Coverage 55.69% 66.85% +11.15%
===========================================
Files 1846 1847 +1
Lines 70302 70821 +519
Branches 7689 7917 +228
===========================================
+ Hits 39157 47347 +8190
+ Misses 29151 21448 -7703
- Partials 1994 2026 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bf3145a
to
fb97563
Compare
1ab490b
to
ee4aa62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending any QA/product reviews
@eschutho have you seen this docker error before? It's preventing me from building an ephemeral. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AAfghahi I was testing this with databricks, and it looks like we still need the validation errors if they are generic db connection issues.
a289dea
to
a3df3da
Compare
: []; | ||
} else if ( | ||
!isEmpty(validationErrors) && | ||
validationErrors?.error_type === 'GENERIC_DB_ENGINE_ERROR' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amended to this @eschutho
/testenv up |
@AAfghahi Ephemeral environment spinning up at http://35.161.176.24:8080. Credentials are |
a3df3da
to
d0ba261
Compare
314eca2
to
d97a2ed
Compare
d97a2ed
to
5730d3b
Compare
/testenv up |
@yousoph Ephemeral environment spinning up at http://54.187.4.90:8080. Credentials are |
a123697
to
3a1eadf
Compare
/testenv up |
@AAfghahi Ephemeral environment spinning up at http://18.236.95.123:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR is trying to dix issues where connection errors where showing up in the advanced tab as opposed to the basic tab in the sql alchemy uri connection modal.
Also, putting more information into the database connection modal.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-11-29.at.11.36.43.AM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION