Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove actions prop and refactor code in SQL Lab #22231

Merged
merged 6 commits into from
Dec 5, 2022
Merged

chore: Remove actions prop and refactor code in SQL Lab #22231

merged 6 commits into from
Dec 5, 2022

Conversation

EugeneTorap
Copy link
Contributor

SUMMARY

Refactor all actions in sqlLab in order to use useDispatch() hook instead of actions prop in every child components.
Also fix type for Query

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #22231 (5d5d39d) into master (a8bc53d) will decrease coverage by 0.00%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master   #22231      +/-   ##
==========================================
- Coverage   66.86%   66.85%   -0.01%     
==========================================
  Files        1840     1840              
  Lines       70161    70193      +32     
  Branches     7657     7662       +5     
==========================================
+ Hits        46910    46925      +15     
- Misses      21281    21294      +13     
- Partials     1970     1974       +4     
Flag Coverage Δ
javascript 53.68% <61.53%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <ø> (ø)
...ntend/src/SqlLab/components/QueryHistory/index.tsx 66.66% <ø> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 55.91% <ø> (ø)
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 49.03% <ø> (ø)
superset-frontend/src/SqlLab/types.ts 57.14% <ø> (ø)
...rontend/src/SqlLab/components/QueryTable/index.tsx 70.17% <16.66%> (ø)
...ontend/src/SqlLab/components/QuerySearch/index.tsx 73.75% <40.00%> (+0.67%) ⬆️
...frontend/src/SqlLab/components/SouthPane/index.tsx 79.54% <85.71%> (+6.81%) ⬆️
...qlLab/components/SaveDatasetActionButton/index.tsx 83.33% <100.00%> (+3.33%) ⬆️
...t-frontend/src/dashboard/util/getOverwriteItems.ts 90.90% <0.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas requested review from AAfghahi and lyndsiWilliams and removed request for AAfghahi November 30, 2022 18:36
@rusackas
Copy link
Member

Pinged a couple committers for review, and might also ask for eyes from @codyml or @eric-briscoe if they have time.

Copy link
Member

@codyml codyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.213.134.150:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@EugeneTorap
Copy link
Contributor Author

@michael-s-molina Can we merge it?

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kgabryje kgabryje merged commit f3bf3ec into apache:master Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Ephemeral environment shutdown and build artifacts deleted.

@EugeneTorap EugeneTorap deleted the refactor/sql-lab-actions branch December 5, 2022 11:24
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants