-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(native-filters): Grid units, type guard, feature flag guard #22307
Conversation
8036fe3
to
bc7baef
Compare
bc7baef
to
5793fb8
Compare
5793fb8
to
1a4daa1
Compare
Codecov Report
@@ Coverage Diff @@
## master #22307 +/- ##
==========================================
- Coverage 65.59% 65.58% -0.02%
==========================================
Files 1847 1847
Lines 70333 70367 +34
Branches 7702 7719 +17
==========================================
+ Hits 46138 46150 +12
- Misses 22197 22218 +21
- Partials 1998 1999 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
This PR follows up on a few comments from previous PRs:
FilterWithDataMask
HORIZONTAL_FILTER_BAR
feature flag is off, so Redux state will match behaviorBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visible changes
TESTING INSTRUCTIONS
filterBarOrientation
set to verticalADDITIONAL INFORMATION
HORIZONTAL_FILTER_BAR