-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Fix dashboard's left side being cut off #22319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22319 +/- ##
==========================================
- Coverage 66.85% 66.85% -0.01%
==========================================
Files 1847 1847
Lines 70482 70483 +1
Branches 7721 7722 +1
==========================================
Hits 47120 47120
Misses 21362 21362
- Partials 2000 2001 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tested locally, LGTM!
/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true |
@geido Ephemeral environment spinning up at http://34.219.231.22:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
When native filter's bar was empty and in horizontal mode, dashboard's left side was cut off. This PR fixes that bug.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION