Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): dashboard actions fail when bad component id exists in children array #22323

Merged
merged 2 commits into from
Dec 5, 2022
Merged

fix(dashboard): dashboard actions fail when bad component id exists in children array #22323

merged 2 commits into from
Dec 5, 2022

Commits on Dec 2, 2022

  1. Adds runtime safety checks to updateComponentParentsList function 

    There are edge cases where a bad / orphan component id can end up on a dashboard layout element's children array.  When this happens it causes critical errors blocking critical dashboard behaviors.  There is still some mystery around the workflow in the code that causes this to occur, but once it does it causes major issues.  This PR makes the updateComponentParentsList runtime safe but additional fixes may be required to resolve underlying cause of bad ids ending up in the dashboard data.

A simulation for this edge case is now covered in the unit tests for updateComponentParentsList

Also adds additional conditional chaining in nativeFilters/utils for additional runtime safety validation if if statements.
    @eric-briscoe
    eric-briscoe committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    0bf5376 View commit details
    Browse the repository at this point in the history

  2. Removes commented out code

    @eric-briscoe
    eric-briscoe committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f427e66 View commit details
    Browse the repository at this point in the history