Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(formatters): [WIP] Adding a few currency formatters #22374

Closed
wants to merge 1 commit into from
Closed

feat(formatters): [WIP] Adding a few currency formatters #22374

wants to merge 1 commit into from

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Dec 8, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas changed the title [WIP] feat(formatters): Adding a few currency formatters feat(formatters): Adding a few currency formatters Dec 8, 2022
@rusackas rusackas marked this pull request as draft December 8, 2022 15:59
@kamalkeshavani-aiinside
Copy link
Contributor

While you are at it, please add the common symbol for JPY and CNY ￥ as well.

@rusackas rusackas changed the title feat(formatters): Adding a few currency formatters feat(formatters): [WIP] Adding a few currency formatters Mar 6, 2023
@rusackas
Copy link
Member Author

rusackas commented Apr 13, 2023 •
edited
Loading

See also: #20075

@ebaratte ebaratte mentioned this pull request Apr 25, 2023
Merged
9 tasks
@rusackas rusackas closed this Jun 26, 2023
@mistercrunch mistercrunch deleted the additional_currency_formatters branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rusackas @kamalkeshavani-aiinside