perf: Prevent rerendering and re-querying metadata of filters in horizontal bar #22389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Because of how the component structure changes when filters move in/out of "More filters" dropdown, the
FilterValue
component is getting unmounted and re-mounted, which causes the whole filter to rerender and resend its metadata query.To prevent that behaviour, this PR uses
react-reverse-portal
to ensure thatFilterValue
component's lifecycle is independent of how its wrappers change. It's a similar pattern that we already use inFilterControls
component.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-12-12.at.15.09.55.mov
After:
Screen.Recording.2022-12-12.at.15.08.08.mov
TESTING INSTRUCTIONS
HORIZONTAL_FILTER_BAR
ffADDITIONAL INFORMATION
CC @codyml for review