Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Stop query in SQL Lab with impala engine (#20950) #22409

Closed
wants to merge 1 commit into from
Closed

fix: Stop query in SQL Lab with impala engine (#20950) #22409

wants to merge 1 commit into from

Conversation

wanghong1314
Copy link
Contributor

@wanghong1314 wanghong1314 commented Dec 13, 2022 •
edited
Loading

SUMMARY

Stop button for queries doesn't work in SQL Lab when using SQL Lab with impala engine and adding Progress Information
Fix the bug:#20950

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After and progress info
image

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@srinify srinify changed the title fix:Stop query in SQL Lab with impala engine (#20950) fix: Stop query in SQL Lab with impala engine (#20950) Dec 13, 2022
wanghong1314
wanghong1314 commented Dec 14, 2022
View reviewed changes
Copy link
Contributor Author

@wanghong1314 wanghong1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submit the relevant code file

@wanghong1314 wanghong1314 changed the title fix: Stop query in SQL Lab with impala engine (#20950) fix:Stop query in SQL Lab with impala engine (#20950) Dec 14, 2022
@rusackas rusackas changed the title fix:Stop query in SQL Lab with impala engine (#20950) fix: Stop query in SQL Lab with impala engine (#20950) Dec 14, 2022
@wanghong1314 wanghong1314 closed this by deleting the head repository Dec 15, 2022
@rusackas
Copy link
Member

@wanghong1314 did you mean to close this out?

CC-ing @eschutho / @yousoph to check this out and see if there's a fix here that we want to adopt.

@rusackas
Copy link
Member

rusackas commented Dec 16, 2022 •
edited
Loading

N/m, there's a new version of the PR open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanghong1314 @rusackas