-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Force configuration for SafeMarkdown component in Handlebars #22417
fix: Force configuration for SafeMarkdown component in Handlebars #22417
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22417 +/- ##
==========================================
- Coverage 66.89% 66.88% -0.01%
==========================================
Files 1847 1847
Lines 70611 70616 +5
Branches 7749 7752 +3
==========================================
Hits 47233 47233
- Misses 21362 21367 +5
Partials 2016 2016
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/packages/superset-ui-core/src/components/SafeMarkdown.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
This PR modifies the Handlebars component so that the configurations for the SafeMarkdown component are applied.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
The Handlebars component should work as expected and behave based on the HTML_SANITIZATION and HTML_SANITIZATION_SCHEMA_EXTENSIONS configuration properties.
ADDITIONAL INFORMATION