fix(sqllab): Overflow bigint in json-tree view #22609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The json explore view in sqllab is displaying incorrect values which seemed to be due to Javascript's max integer on 64 bit IDs.
This commit updates the JSON.parser by JSONBig parser as well as custom rendering logic to trim the unnecessary quote format in a bigint string format.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before--bigint-in-json-tree.mov
after--bigint-in-json-tree.mov
TESTING INSTRUCTIONS
specs are added
ADDITIONAL INFORMATION
@ktmud cc: @john-bodley