feat: Add logging for ssh tunneling test_connection attempts #22625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22625 +/- ##
==========================================
+ Coverage 67.07% 67.12% +0.05%
==========================================
Files 1869 1869
Lines 71591 72128 +537
Branches 7822 7822
==========================================
+ Hits 48018 48418 +400
- Misses 21544 21681 +137
Partials 2029 2029
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
craig-rueda
reviewed
Jan 11, 2023
| @@ -105,7 +117,7 @@ def run(self) -> None: # pylint: disable=too-many-statements | |||
| ssh_tunnel = SSHTunnel(**ssh_tunnel) | |||
|
|
|||
| event_logger.log_with_context( | |||
| action="test_connection_attempt", | |||
| action=get_log_connection_action("test_connection_attempt", ssh_tunnel), | |||
AAfghahi
requested changes
Jan 12, 2023
| engine=database.db_engine_spec.__name__, | ||
| ) | ||
| # bubble up the exception to return a 408 | ||
| raise ex | ||
| except Exception as ex: | ||
| event_logger.log_with_context( | ||
| action=f"test_connection_error.{ex.__class__.__name__}", | ||
| action=get_log_connection_action("test_connection_error", ssh_tunnel), |
AAfghahi
approved these changes
Jan 12, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With ssh tunneling being rolled out, we want to start instrument and verify these connections are successful. To do this i've created a new function to append context of the ssh tunneling to the
actionfield so ETL can parse this accordingly.Another approach is creating a new column specifically to annotate whether this connection has ssh tunnel enabled.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION