Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stringify ValueErrors for NaT types #22628

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Jan 6, 2023

SUMMARY

similar to https://github.com/apache/superset/pull/22321/files, PyArrow will through a ValueError if converting an NaT type to a pa.array. I'm using the same stringify function that we're using for TypeErrors here.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
_DEV__Superset

After:
_DEV__Superset

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/athena-null-datetime branch from 99986f6 to 7c31c6f Compare January 6, 2023 22:52
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #22628 (7c31c6f) into master (71982ee) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22628      +/-   ##
==========================================
+ Coverage   66.91%   67.03%   +0.11%     
==========================================
  Files        1850     1858       +8     
  Lines       70695    71018     +323     
  Branches     7750     7750              
==========================================
+ Hits        47309    47605     +296     
- Misses      21370    21397      +27     
  Partials     2016     2016              
Flag Coverage Δ
hive 52.48% <ø> (+0.01%) ⬆️
mysql 78.04% <ø> (+0.05%) ⬆️
postgres 78.10% <ø> (+0.04%) ⬆️
presto 52.37% <ø> (+0.01%) ⬆️
python 81.36% <ø> (+0.09%) ⬆️
sqlite 76.49% <ø> (-0.03%) ⬇️
unit 51.48% <ø> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/result_set.py 97.85% <ø> (ø)
superset/dashboards/filter_state/commands/utils.py 80.00% <0.00%> (-10.00%) ⬇️
...uperset/dashboards/filter_state/commands/delete.py 91.30% <0.00%> (-4.35%) ⬇️
superset/databases/commands/update.py 75.86% <0.00%> (-4.14%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
...uperset/dashboards/filter_state/commands/update.py 96.66% <0.00%> (-3.34%) ⬇️
superset/examples/birth_names.py 70.00% <0.00%> (-1.43%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/databases/commands/test_connection.py 97.43% <0.00%> (-1.24%) ⬇️
superset/sql_lab.py 81.13% <0.00%> (-1.00%) ⬇️
... and 40 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho merged commit 804e89d into apache:master Jan 6, 2023
@sadpandajoe
Copy link
Member

🏷️ preset:2023.01

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jan 6, 2023
@eschutho eschutho deleted the elizabeth/athena-null-datetime branch February 3, 2023 23:03
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2023.01 size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants