Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssh-tunnel): wrap pkey into StringIO buffer before creating the tunnel #22763

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jan 17, 2023

SUMMARY

Adding StringIO to wrap value before creating the tunnel to allow the pkg to properly read the private key needed to create the tunnel.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title fix(ssh-tunnel): wrap pkey into file before creating the tunnel fix(ssh-tunnel): wrap pkey into StringIO buffer before creating the tunnel Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #22763 (2fd3c11) into master (c58dbf8) will decrease coverage by 11.31%.
The diff coverage is 40.00%.

❗ Current head 2fd3c11 differs from pull request most recent head 0966107. Consider uploading reports for the commit 0966107 to get more accurate results

@@             Coverage Diff             @@
##           master   #22763       +/-   ##
===========================================
- Coverage   67.23%   55.92%   -11.31%     
===========================================
  Files        1876     1876               
  Lines       71814    71818        +4     
  Branches     7863     7863               
===========================================
- Hits        48284    40165     -8119     
- Misses      21504    29627     +8123     
  Partials     2026     2026               
Flag Coverage Δ
hive 52.59% <40.00%> (-0.01%) ⬇️
postgres ?
presto 52.49% <40.00%> (-0.01%) ⬇️
python 58.29% <40.00%> (-23.56%) ⬇️
sqlite ?
unit 51.53% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/extensions/ssh.py 64.10% <40.00%> (-1.62%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/tags/core.py 4.54% <0.00%> (-95.46%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-90.91%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-87.88%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-84.00%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/create.py 30.61% <0.00%> (-69.39%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-69.00%) ⬇️
... and 293 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit c536f71 into master Jan 17, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the ssh-tunnel-rsa-wrap branch March 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants