Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding missing examples in the gallery for some chart types #22766

Merged

Conversation

yash-samsung
Copy link
Contributor

SUMMARY

Adding chart examples in the gallery which were missing for below chart types:

  1. Mixed Time-Series
  2. Parallel Coordinates
  3. Partition Chart
  4. Pivot Table (legacy)
  5. Pivot Table v2
  6. Time-Series Table
  7. Time-Series Percent Change

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
pr_before
(Please note that text in red 'No Example' just to show/visualize that there are no examples. In actual, it remains empty)

After:
pr_after

As it can be seen in after image, examples will be loaded for all the seven chart types mentioned above.

TESTING INSTRUCTIONS

At the time of selecting a chart type from the gallery, examples will be visible on UI for all the sever mentioned chart types.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes a part of [Gallery] Some chart type in gallery do not have example #16707
  • Required feature flags:
  • Changes UI: Only examples will be loaded on UI. It won't change the way user interacts with UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…aired t-test Table, Parallel Coordinates, Partition Chart, Pivot Table, Pivot Table v2, Time-series Period Pivot, Time-series Table and Time-series Percent Change
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #22766 (5df8e5f) into master (ad758c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22766   +/-   ##
=======================================
  Coverage   67.26%   67.26%           
=======================================
  Files        1875     1875           
  Lines       71762    71762           
  Branches     7854     7854           
=======================================
  Hits        48268    48268           
  Misses      21469    21469           
  Partials     2025     2025           
Flag Coverage Δ
javascript 53.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...acy-plugin-chart-parallel-coordinates/src/index.js 66.66% <ø> (ø)
...plugins/legacy-plugin-chart-partition/src/index.js 66.66% <ø> (ø)
...ugins/legacy-plugin-chart-pivot-table/src/index.js 66.66% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/Compare/index.js 66.66% <ø> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/index.ts 25.00% <ø> (ø)
...ugins/plugin-chart-pivot-table/src/plugin/index.ts 66.66% <ø> (ø)
...set-frontend/src/visualizations/TimeTable/index.ts 66.66% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you again!

@rusackas rusackas merged commit aca2f1b into apache:master Jan 18, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants