Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(welcome): harmonize submenu with other routes #22803

Merged
merged 7 commits into from
Mar 31, 2023

Conversation

villebro
Copy link
Member

SUMMARY

The welcome page submenu currently does not use the same SubMenu component that's used on the other routes, like Dashboard, Chart, Dataset etc, causing it to deviate from the normal look and feel. This fixes that. At the same time I noticed that we were using a re-export of FeatureFlag from @superset-ui/core in lots of places, which I believe is a remnant from the multirepo days. This removes the export and replaces all occurences with a direct import from @superset-ui/core.

AFTER

Now the Welcome page looks the same as the other pages:
image

BEFORE

Previously the "Home" text had a different font size, and the text next to the toggle was not using the proper theme.
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro force-pushed the villebro/welcome-submenu branch 2 times, most recently from 38f1c04 to 42ec5a4 Compare January 20, 2023 16:33
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #22803 (614449f) into master (0fa4212) will increase coverage by 0.00%.
The diff coverage is 85.00%.

❗ Current head 614449f differs from pull request most recent head 640a45d. Consider uploading reports for the commit 640a45d to get more accurate results

@@           Coverage Diff           @@
##           master   #22803   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files        1909     1910    +1     
  Lines       73743    73749    +6     
  Branches     7987     7987           
=======================================
+ Hits        49888    49894    +6     
  Misses      21814    21814           
  Partials     2041     2041           
Flag Coverage Δ
javascript 53.85% <85.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <ø> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 64.50% <ø> (ø)
...d/src/SqlLab/components/ShareSqlLabQuery/index.tsx 81.48% <ø> (ø)
...frontend/src/SqlLab/components/SouthPane/index.tsx 79.54% <ø> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 56.68% <ø> (ø)
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 49.47% <ø> (ø)
superset-frontend/src/components/Chart/Chart.jsx 55.35% <ø> (ø)
...erset-frontend/src/components/Chart/chartAction.js 55.34% <ø> (ø)
...end/src/components/Datasource/DatasourceEditor.jsx 65.35% <ø> (ø)
...tend/src/components/Datasource/DatasourceModal.tsx 69.76% <ø> (ø)
... and 40 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the awesome improvements!

@villebro villebro merged commit f6b5b65 into apache:master Mar 31, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants