-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(welcome): harmonize submenu with other routes #22803
Conversation
38f1c04
to
42ec5a4
Compare
42ec5a4
to
3927940
Compare
41ffe77
to
fb3f4a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #22803 +/- ##
=======================================
Coverage 67.65% 67.65%
=======================================
Files 1909 1910 +1
Lines 73743 73749 +6
Branches 7987 7987
=======================================
+ Hits 49888 49894 +6
Misses 21814 21814
Partials 2041 2041
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the awesome improvements!
SUMMARY
The welcome page submenu currently does not use the same
SubMenu
component that's used on the other routes, like Dashboard, Chart, Dataset etc, causing it to deviate from the normal look and feel. This fixes that. At the same time I noticed that we were using a re-export ofFeatureFlag
from@superset-ui/core
in lots of places, which I believe is a remnant from the multirepo days. This removes the export and replaces all occurences with a direct import from@superset-ui/core
.AFTER
Now the Welcome page looks the same as the other pages:
BEFORE
Previously the "Home" text had a different font size, and the text next to the toggle was not using the proper theme.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION