Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Could not remove metrics in Explore #22936

Closed
wants to merge 1 commit into from
Closed

Conversation

geido
Copy link
Member

@geido geido commented Feb 1, 2023

SUMMARY

This PR #22707 moved the stopPropagation event downstream but wasn't removed upstream causing a bug with removing metrics.

BEFORE

215146205-c9f67d24-ffae-4135-893a-6f6a5b389fb0.mov

TESTING INSTRUCTIONS

  • Run query in SQL lab and create chart OR create a chart from a dataset
  • Add metric
  • Try to delete it via clicking "x"
  • The metric should be deleted successfully

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from kgabryje February 1, 2023 13:09
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #22936 (7a5d26b) into master (ede18be) will decrease coverage by 11.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #22936       +/-   ##
===========================================
- Coverage   67.37%   56.35%   -11.02%     
===========================================
  Files        1876     1876               
  Lines       72061    72061               
  Branches     7864     7864               
===========================================
- Hits        48550    40613     -7937     
- Misses      21491    29428     +7937     
  Partials     2020     2020               
Flag Coverage Δ
hive 52.73% <ø> (ø)
mysql ?
postgres ?
presto 52.62% <ø> (ø)
python 59.13% <ø> (-22.92%) ⬇️
sqlite ?
unit 52.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nents/controls/MetricControl/AdhocMetricOption.jsx 77.77% <ø> (ø)
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/tags/core.py 4.54% <0.00%> (-95.46%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-90.91%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-87.88%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-84.00%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/create.py 30.61% <0.00%> (-69.39%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-69.00%) ⬇️
... and 284 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina
Copy link
Member

michael-s-molina commented Feb 1, 2023

@geido Can we close this in favor of #22940? We can't remove the stopPropagation because it will trigger the popup when removing the last temporal column before the user confirms the action.

@geido geido closed this Feb 1, 2023
@mistercrunch mistercrunch deleted the fix/remove-metric branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants